Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] 패키지 리팩토링 #222

Merged
merged 3 commits into from
Jan 24, 2024
Merged

[CHORE] 패키지 리팩토링 #222

merged 3 commits into from
Jan 24, 2024

Conversation

thguss
Copy link
Collaborator

@thguss thguss commented Jan 23, 2024 •
edited
Loading

Related Issue 🚀

Work Description ✏️

  • 사용 목적에 따라 패키지 및 클래스를 분리했습니다.

PR Point 📸

  • 추후 인수인계 과정에서 이해하기 어려운 패키지 분리가 있어보여 리팩토링 했습니다.
  • 다양한 피드백 있으시면 해주시면 감사하겠습니다!

@thguss thguss added sohyeon 소현 작업 chore 잡일 labels Jan 23, 2024
@thguss thguss requested a review from dragontaek-lee January 23, 2024 16:12
@thguss thguss self-assigned this Jan 23, 2024
dragontaek-lee
dragontaek-lee approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@dragontaek-lee dragontaek-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우왓 너무 너무 좋습니다!
혹시 config 파일도 있고, security 안에 config도 있는데 이거도 config에 다 넣는 것에 대해서는 어떻게 생각하시나요!?

@thguss thguss added this pull request to the merge queue Jan 24, 2024
Merged via the queue into develop with commit e3282c8 Jan 24, 2024
1 check passed
@thguss thguss deleted the sohyeon_#221 branch January 24, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragontaek-lee dragontaek-lee dragontaek-lee approved these changes

Assignees

@thguss thguss

Labels
chore 잡일 size/L sohyeon 소현 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 패키지 구조 리팩토링
2 participants
@thguss @dragontaek-lee