[FEAT] 알림 어드민 API 개발 #173
Merged
[FEAT] 알림 어드민 API 개발 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragontaek-lee
approved these changes
Oct 26, 2023
| @ApiOperation("알림 리스트 조회") | ||
| @GetMapping | ||
| public ResponseEntity<ApiResponse> getAlarms( | ||
| @RequestParam(required = false) Integer generation, |
There was a problem hiding this comment.
네! 세션 생성에서도 generation 값을 받고 있어서 통일되게 작성했어요!
| ) { | ||
| public Alarm toEntity() { |
There was a problem hiding this comment.
오 이거 새롭네요..! 나중에 다른거도 이렇게 하면 좋겠네요 좋아요!
| @@ -64,8 +65,13 @@ public Alarm(AlarmRequestDTO requestDTO) { | |||
| this.title = requestDTO.title(); | |||
There was a problem hiding this comment.
코드리뷰에 잡히지 않아서 커서를 여기다 두었는데,
혹시 이부분 List으로 변경할수 있을까요?! 알림서버에서 스트링값으로 받고 있어서!(dynamoDB)
늦게 이야기해서 죄송합니다 ㅠㅠ
@Column(columnDefinition = "TEXT")
@Convert(converter = LongListConverter.class)
private List<Long> targetList;
There was a problem hiding this comment.
String 타입의 리스트를 말하는거죠??
| Part part, | ||
| List<Long> targetList, | ||
| Status status | ||
| List<Long> targetList |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
[FEAT] 알림 어드민 API 개발 #173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🚀
Work Description ✏️
PR Point 📸
아래와 같은 조건으로 API를 설계했어요. 참고 부탁드려요~!