[REFACTOR] 출석 중 결석 판별 메소드화

sopt-makers · Feb 15, 2024 · dca3eda · dca3eda
1 parent 9d03d55
commit dca3eda
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/...pi/src/main/java/org/sopt/makers/operation/app/lecture/service/AppLectureServiceImpl.java b/...pi/src/main/java/org/sopt/makers/operation/app/lecture/service/AppLectureServiceImpl.java
@@ -73,6 +73,11 @@ private void checkAttendancesSize(List<Attendance> attendances) {
         }
     }
 
+    private boolean checkOnAttendanceAbsence(SubLecture subLecture, SubAttendance subAttendance) {
+        val isOnAttendanceCheck = LocalDateTime.now().isBefore(subLecture.getStartAt().plusMinutes(10));
+        return isOnAttendanceCheck && subAttendance.getStatus().equals(ABSENT);
+    }
+
     private Attendance getNowAttendance(List<Attendance> attendances) {
         val index = getAttendanceIndex();
         return attendances.get(index);
@@ -97,9 +102,8 @@ private String getMessage(Attribute attribute) {
 
     private TodayLectureResponse getTodayFirstLectureResponse(SubAttendance subAttendance, LectureResponseType responseType, Lecture lecture) {
         val subLecture = subAttendance.getSubLecture();
-        val isOnAttendanceCheck = LocalDateTime.now().isBefore(subLecture.getStartAt().plusMinutes(10));
         val message = getMessage(lecture.getAttribute());
-        if (isOnAttendanceCheck && subAttendance.getStatus().equals(ABSENT)) {
+        if (checkOnAttendanceAbsence(subLecture, subAttendance)) {
             return TodayLectureResponse.of(responseType, lecture, message, Collections.emptyList());
         }
         return TodayLectureResponse.of(responseType, lecture, message, Collections.singletonList(subAttendance));
@@ -112,9 +116,8 @@ private TodayLectureResponse getTodaySecondLectureResponse(
     ) {
         val subAttendance = subAttendances.get(1);
         val subLecture = subAttendance.getSubLecture();
-        val isOnAttendanceCheck = LocalDateTime.now().isBefore(subLecture.getStartAt().plusMinutes(10));
         val message = getMessage(lecture.getAttribute());
-        if (isOnAttendanceCheck && subAttendance.getStatus().equals(ABSENT)) {
+        if (checkOnAttendanceAbsence(subLecture, subAttendance)) {
             return TodayLectureResponse.of(responseType, lecture, message, Collections.singletonList(subAttendances.get(0)));
         }
         return TodayLectureResponse.of(responseType, lecture, message, subAttendances);