Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 번쩍 도메인 네이밍 lightning -> flash로 변경 #544

Merged
merged 7 commits into from
Jan 25, 2025

Conversation

hoonyworld
Copy link
Member

@hoonyworld hoonyworld commented Jan 24, 2025

👩‍💻 Contents

image
  • 번쩍 도메인 네이밍을 lightning에서 flash로 변경하였습니다.
  • 따라서 lightning 관련 enum, dto 등의 모든 관련 코드의 네이밍을 flash로 변경하였습니다.

📝 Review Note

📣 Related Issue

✅ 점검사항

  • docker-compose.yml 파일에 마이그레이션 한 API의 포워딩을 변경해줬나요?
  • Spring Secret 값을 수정하거나 추가했다면 Github Secret에서 수정을 해줬나요?
  • Nestjs Secret 값을 수정하거나 추가했다면 Docker-Compose.yml 파일 및 인스턴스 내부의 .env 파일을 수정했나요?

@hoonyworld hoonyworld added the 🪛 chore 기능 수정 label Jan 24, 2025
@hoonyworld hoonyworld requested a review from mikekks January 24, 2025 06:46
@hoonyworld hoonyworld self-assigned this Jan 24, 2025
@hoonyworld hoonyworld linked an issue Jan 24, 2025 that may be closed by this pull request
1 task
Copy link

height bot commented Jan 24, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

mikekks
mikekks previously approved these changes Jan 24, 2025
Copy link
Member

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!!

@hoonyworld hoonyworld merged commit 96ebe1f into develop Jan 25, 2025
1 check passed
@mikekks mikekks deleted the chore/#543 branch January 25, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: 번쩍 도메인 네이밍 변경
2 participants