[FEAT] 플레이그라운드 채용정보 조회 기능 API - #436 #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kseysh
reviewed
Nov 14, 2024
Comment on lines
+62
to
+65
| @GetMapping("/employments") | ||
| public ResponseEntity<List<EmploymentPostResponse>> getEmploymentPosts( | ||
| @AuthenticationPrincipal User user | ||
| ) { |
There was a problem hiding this comment.
P2. Size는 유동적으로 변할 수 있도록 파라미터로 받는 것이 좋을 것 같은데 어떻게 생각하시나요?
Comment on lines
168
to
174
| .map(post -> EmploymentPostResponse.builder() | ||
| .id(post.id()) | ||
| .categoryName(post.categoryName()) | ||
| .title(post.title()) | ||
| .content(post.content()) | ||
| .images(post.images()) | ||
| .build()) |
There was a problem hiding this comment.
P3. EmploymentPostResponse에 PostInfo 메서드를 전달하면 EmploymentPostResponse에 맞는 객체를 전달해주는 of 메서드가 있다면 가독성이 더 좋아질 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR Summary
🌴 Works
🌱 Related Issue
closed #436
🌵 PR 참고사항