[#1012] 간단한 화면에서 MVVM Like 구조 없이 상태관리할 수 있게 구조 변경 #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
l2hyunwoo
force-pushed
the
feature/#1012
branch
from
a0eccc6 to
8d2b1f1
Compare
giovannijunseokim
approved these changes
Jan 9, 2025
Comment on lines
+30
to
+38
| inline fun <reified T> Context.findActivity(): T? { | ||
| var context = this | ||
| while (context is ContextWrapper) { | ||
| if (context is T) { | ||
| return context | ||
| } | ||
| context = context.baseContext | ||
| } | ||
| return null |
There was a problem hiding this comment.
개인적으로 해당 함수에서 null이 반환될 경우 그 이유를 JavaDoc으로 적어주시면 좋을 것 같아요! 해당 함수는 이후 기수분들도 많이 사용할 것 같아서요.
l2hyunwoo
commented
Jan 9, 2025
Comment on lines
+42
to
+47
| fun rememberMyPageUiState( | ||
| userActiveState: UserActiveState, | ||
| authRepository: AuthRepository, | ||
| stampRepository: StampRepository, | ||
| onRestartApp: () -> Unit | ||
| ): MyPageUiState { |
There was a problem hiding this comment.
Redux Toolkit -> React Hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this issue?
Screen_recording_20250105_123315.mp4
Reference