chore: update to Node 20.x #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noomorph
commented
Dec 21, 2023
| @@ -3,10 +3,6 @@ import { tablesData } from 'consts'; | |||
| import { getAllDataFromResults, IAllData } from 'utils/getAllDataFromResults'; | |||
| import { getTableDataUrl } from 'utils/getTableDataUrl'; | |||
|
|
|||
| // eslint-disable-next-line | |||
| // @ts-ignore | |||
| const fetch = typeof CLIENT !== 'undefined' && CLIENT ? window.fetch : require('node-fetch'); | |||
There was a problem hiding this comment.
Node 20.x has fetch by default, just in case if someone wonders.
Pull Request Test Coverage Report for Build 7285070694
💛 - Coveralls |
noomorph
commented
Dec 21, 2023
| @@ -7,6 +7,7 @@ | |||
| "emitDecoratorMetadata": true, | |||
| "experimentalDecorators": true, | |||
| "removeComments": false, | |||
| "importHelpers": true, | |||
There was a problem hiding this comment.
Some updated libraries bring import * from 'tslib', so it's best to use tslib for ourselves as well not to bloat the bundle any further.
noomorph
commented
Dec 21, 2023
| @@ -69,7 +69,7 @@ html, body { | |||
| } | |||
|
|
|||
| #app, input, select, button, a, textarea { | |||
| font-family: Roboto, sans-serif; | |||
| font-family: Roboto, -apple-system, BlinkMacSystemFont, "Segoe UI", "Liberation Sans", Arial, sans-serif; | |||
There was a problem hiding this comment.
Added macOS, Windows and Linux fallbacks.
ru-danko
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #218, #223, #224, #225, #226, #227, #231, #233, #234, #235, #236, #237.
Updates required Node runtime to 20.x (latest LTS).
Fixes fallback font query to be more friendly to macOS and Linux.