Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SAI submodule to pick the voq counter support added in sai-thrift #1336

Conversation

saksarav-nokia
Copy link
Contributor

Updated the SAI submodule to pick the sai-thrift changes made to support voq counters

@saksarav-nokia
Copy link
Contributor Author

@kcudnik @vmittal-msft , please review this

@saksarav-nokia
Copy link
Contributor Author

@kcudnik @vmittal-msft , The test failures are not related to my changes. Can you restart the tests

@vmittal-msft
Copy link
Contributor

@arlakshm @rlhui we are planning to have this for master only? and add to 202205 later. if so, we can cancel this PR. Please confirm.

@vmittal-msft
Copy link
Contributor

@saksarav-nokia we have master PR merged for the same ?

@saksarav-nokia
Copy link
Contributor Author

@saksarav-nokia we have master PR merged for the same ?

Yes @vmittal-msft

@saksarav-nokia
Copy link
Contributor Author

@rlhui
Copy link

rlhui commented Jan 25, 2024

@arlakshm @rlhui we are planning to have this for master only? and add to 202205 later. if so, we can cancel this PR. Please confirm.

@saksarav-nokia - there's no plan to update this for 202205. Please close this.

@saksarav-nokia
Copy link
Contributor Author

closing as per Rita's request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants