Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump timeout limit in reliable tsa test #16790

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

cyw233
Copy link
Contributor

@cyw233 cyw233 commented Feb 5, 2025

Description of PR

Bump the timeout limit in reliable tsa test to make the test more stable.

Summary:
Fixes # (issue) Microsoft ADO 31235033

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Previously, we discussed in the Cisco sync-up meeting to increase the time diff limit and bgp wait timeout in bgp/test_startup_tsa_tsb_service.py: #16638. We need to make similar changes to bgp/test_reliable_tsa.py as we are seeing similar flaky issues in it.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@cyw233 cyw233 requested a review from StormLiangMS as a code owner February 5, 2025 03:04
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cyw233 cyw233 changed the title chore: bump wait timeout in reliable tsa chore: bump timeout limit in reliable tsa test Feb 5, 2025
@cyw233 cyw233 removed the request for review from StormLiangMS February 5, 2025 03:10
Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 4543422 into sonic-net:master Feb 5, 2025
15 of 16 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 5, 2025
Description of PR
Bump the timeout limit in reliable tsa test to make the test more stable.

Summary:
Fixes # (issue) Microsoft ADO 31235033

Approach
What is the motivation for this PR?
Previously, we discussed in the Cisco sync-up meeting to increase the time diff limit and bgp wait timeout in bgp/test_startup_tsa_tsb_service.py: sonic-net#16638. We need to make similar changes to bgp/test_reliable_tsa.py as we are seeing similar flaky issues in it.

co-authorized by: [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16810

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#61

mssonicbld pushed a commit that referenced this pull request Feb 7, 2025
Description of PR
Bump the timeout limit in reliable tsa test to make the test more stable.

Summary:
Fixes # (issue) Microsoft ADO 31235033

Approach
What is the motivation for this PR?
Previously, we discussed in the Cisco sync-up meeting to increase the time diff limit and bgp wait timeout in bgp/test_startup_tsa_tsb_service.py: #16638. We need to make similar changes to bgp/test_reliable_tsa.py as we are seeing similar flaky issues in it.

co-authorized by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants