-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump timeout limit in reliable tsa test #16790
Merged
yejianquan
merged 1 commit into
sonic-net:master
from
cyw233:bump-time-diff-in-reliable-tsa
Feb 5, 2025
Merged
chore: bump timeout limit in reliable tsa test #16790
yejianquan
merged 1 commit into
sonic-net:master
from
cyw233:bump-time-diff-in-reliable-tsa
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yejianquan
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 5, 2025
Description of PR Bump the timeout limit in reliable tsa test to make the test more stable. Summary: Fixes # (issue) Microsoft ADO 31235033 Approach What is the motivation for this PR? Previously, we discussed in the Cisco sync-up meeting to increase the time diff limit and bgp wait timeout in bgp/test_startup_tsa_tsb_service.py: sonic-net#16638. We need to make similar changes to bgp/test_reliable_tsa.py as we are seeing similar flaky issues in it. co-authorized by: [email protected]
Cherry-pick PR to 202411: #16810 |
11 tasks
11 tasks
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#61 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 7, 2025
Description of PR Bump the timeout limit in reliable tsa test to make the test more stable. Summary: Fixes # (issue) Microsoft ADO 31235033 Approach What is the motivation for this PR? Previously, we discussed in the Cisco sync-up meeting to increase the time diff limit and bgp wait timeout in bgp/test_startup_tsa_tsb_service.py: #16638. We need to make similar changes to bgp/test_reliable_tsa.py as we are seeing similar flaky issues in it. co-authorized by: [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Bump the timeout limit in reliable tsa test to make the test more stable.
Summary:
Fixes # (issue) Microsoft ADO 31235033
Type of change
Back port request
Approach
What is the motivation for this PR?
Previously, we discussed in the Cisco sync-up meeting to increase the time diff limit and bgp wait timeout in
bgp/test_startup_tsa_tsb_service.py
: #16638. We need to make similar changes tobgp/test_reliable_tsa.py
as we are seeing similar flaky issues in it.How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation