This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Fix new services require bot restart #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix LSP errors
Remove service lists from Parser and Burger bot and instead pass the services to `Parser.parse()` method in order to have a single source of truth when parser. This fixes the issue where a user adds a service but it isn't parsed until the bot is restarted.
Fix services not updated for parsing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that currently when a new service is added it isn't being parsed due to the
BurgerBot.servicesfield not being updated when a new service is added by a user, also this field is passed as a reference to the Parser but also later on replaced by a new list object.In order to fix this issue I created a single source of truth, the users, and every time when the parse function is called the currently looked for services are aggregated and sent to the
Parser.parsemethod.I also changed to user field to a dictionary to help with finding the user when performing user specific operations such as adding or removing a service.
Other then that, there are also some fixes to the type hints.