Add a step option for increment integer provider #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhagenbourger
force-pushed
the
feature/increment_by_step
branch
3 times, most recently
from
97035cc to
7e3c5e7
Compare
src/providers/increment/integer.rs
Outdated
| let step_option = column["step"].as_i64().unwrap_or(DEFAULT_STEP) as i32; | ||
| let mut param_step: i32 = DEFAULT_STEP as i32; | ||
|
|
||
| if step_option != 0 { |
There was a problem hiding this comment.
It does not make sense to have a step of 0 you are right, but the behavior is not bad and has an expected logic
So we think that being able to put 0 can be kept
There was a problem hiding this comment.
Thank you for your feedback @vianneybacoup
I amended my commit to allow 0 value for step option.
bhagenbourger
force-pushed
the
feature/increment_by_step
branch
from
7e3c5e7 to
cfc0dfe
Compare
vianneybacoup
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19