Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3 support #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add python3 support #14

wants to merge 1 commit into from

Conversation

gargi
Copy link

@gargi gargi commented Oct 10, 2016

This PR addresses issue #11

@davecap
Copy link
Member

davecap commented Oct 10, 2016

Thanks! we will review your PR as soon as possible.

@gargi
Copy link
Author

gargi commented Oct 10, 2016

yes! Please let me know if you have any feedback!

@davecap
Copy link
Member

davecap commented Oct 16, 2016

It looks like there might be a few things that broke with the switch to next() instead of obj.next(). See the tests:

It may be possible to fix this by adding the following function to the FileReader class:

def __next__(self):
        return self.next()

Although I'm not sure if that will fix the problem. Are you able to get the tests to run locally in Python 2.7 and Python 3.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants