Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download all files from a Catalog at once #48 #57

Merged
merged 11 commits into from
Jun 13, 2024
Merged

Download all files from a Catalog at once #48 #57

merged 11 commits into from
Jun 13, 2024

Conversation

safimuhammad
Copy link

  • Catalog can now download max_download or any number of files given by the user.
  • A test for this feature is also written.

@safimuhammad
Issue # 43 : download all files from Catalog
852e6d5 
tests also written

Signed-off-by: safimuhammad <[email protected]>
@safimuhammad safimuhammad changed the base branch from main to develop June 6, 2024 07:34
@safimuhammad
Issue # 43 : download all files from Catalog
0333c03 
tests also written

Signed-off-by: safimuhammad <[email protected]>
ebuchlin
ebuchlin reviewed Jun 10, 2024
View reviewed changes
@safimuhammad
- Cleared the duplication
ab95466 
- Catalog.download_files() now calls FileMetadata.download_file()

Signed-off-by: safimuhammad <[email protected]>
@safimuhammad safimuhammad requested a review from ebuchlin June 11, 2024 04:55
ebuchlin
ebuchlin reviewed Jun 12, 2024
View reviewed changes
@safimuhammad
Copy link
Author

safimuhammad commented Jun 13, 2024 •
edited
Loading

Changes done as said,

  • Downloader is now a single object instead of multiple for each file.
  • auto downloads if none in downloader.
    ps. I see the duplication but this seems to be the best way to implement this without rewriting the already running filemetadata.download_file()

@safimuhammad safimuhammad requested a review from ebuchlin June 13, 2024 08:37
ebuchlin
ebuchlin approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@ebuchlin ebuchlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I have added minor changes and I will merge

@ebuchlin ebuchlin merged commit 2ee184e into solo-spice:develop Jun 13, 2024
@safimuhammad
Copy link
Author

It's fun working on this, and you're incredibly helpful thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchlin ebuchlin ebuchlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@safimuhammad @ebuchlin