Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023 redesign css updates #855
base: 2023-redesign-css-updates
Are you sure you want to change the base?
2023 redesign css updates #855
Changes from 20 commits
979cb14
cdcb68c
e400251
f7a756e
6000745
c52dbbe
d0d93fb
d50ffb7
37f18c1
1782514
ba46049
72532bb
d4094f8
68181a5
382485b
4846380
565bf85
361eb89
49f534e
e9bafaf
49e8f97
53e8517
96cd8f4
d13322b
e6eac52
8e7ee56
29f78e3
22a11f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's currently on the website is most comprehensive and up to date. Any particular reason to direct people to the forum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not part of my update (I only removed the class button).
I agree that https://solidproject.org/apps is (probably) better, but then we should add that page to the new redesign as well.
Maybe @KyraAssaad have some thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I included
content
in the original but it is not necessary if the date is always going to be yyyy-mm-dd without time. The precision is the same. Value from the text content will be used. If the precision for the machine-readable is desired, and the human gets less precise in text content, thencontent
can be handy.Not sure if you want to follow this pattern for the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong opinions on this, but in general I think less is better. Do you want me to remove all uses of
content="[date]"
in the HTML?