Add WebView error handling to Example Web App #1083
Conversation
| @@ -54,7 +43,30 @@ function App({ children }: { children: ReactNode }) { | |||
| /** | |||
| * Note that you don't have to include the SolanaMobileWalletAdapter here; | |||
| * It will be added automatically when this app is running in a compatible mobile context. | |||
| * | |||
| * However, it is recommended to manually include the SolanaSolanaMobileWalletAdapter | |||
There was a problem hiding this comment.
SolanaSolana! nice catch, fixed
| uri: getUriForAppIdentity(), | ||
| }, | ||
| authorizationResultCache: createDefaultAuthorizationResultCache(), | ||
| chain: 'solana:testnet', |
There was a problem hiding this comment.
This should use Devnet, consistent iwith the CLUSTER variable?
| onWalletNotFound: async (mobileWalletAdapter: SolanaMobileWalletAdapter) => { | ||
| if (typeof window !== 'undefined') { | ||
| const userAgent = window.navigator.userAgent.toLowerCase(); | ||
| if (userAgent.includes('wv')) { // Android WebView |
There was a problem hiding this comment.
Is there a more precise way to check for Android Webview? Wondering if there's ever a case where a non-Android Webview also has "wv" in the userAgent.
There was a problem hiding this comment.
from my research, this is a reliable way to detect Android WebView on Lollipop and higher.
As far as non-android, that should not happen. since MWA is only loaded on Android. If we are on iOS for example. we wont ever get here.
Even so, if we get here its because MWA failed. There is not much we can do apart from either routing the user to the wallets page, or showing some kind of error.
I could change up the logic here to do an android check, and only route to the wallets webpage if we believe we are indeed in a compatible browser and therefore the user likely does not have a wallet installed. Honestly IMO its the assuming the user does not have a wallet part that we should be questioning here.
There was a problem hiding this comment.
I think we should change up the UX here entirely. We should never auto route to the wallets page, that UX sucks. We should show a dialog with something like:
We did not find a compatible wallet installed on the device
And depending on what browser we think we are in either:
You can see a list of compatible wallets here
or:
This browser does not appear to support MWA
Something like this. Because we don't actually ever know for sure if the user does not have a wallet installed. Its possible they just dismissed the browser exit warning, or dismissed the disambiguation dialog.
There was a problem hiding this comment.
The default implementation routes to the wallets page because there is not much else we can do. We cannot show UI from the library.
Adds an error snackbar if a compatible MWA wallet is not found, and the app is running in a webview. See #1082