temporary fix for maxSdkVersion attribute parsing #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdlaver
requested changes
Apr 2, 2023
| if (permission[1] === undefined) | ||
| return permission[3] | ||
| else | ||
| return permission[1] + " maxSdkVersion=" + permission[2] |
There was a problem hiding this comment.
I'd recommend we add a comment here noting that this format will change in the future, with a link to the GitHub issue.
| @@ -283,7 +283,7 @@ const getAndroidDetails = async ( | |||
| const minSdk = new RegExp( | |||
| AaptPrefixes.sdkPrefix + AaptPrefixes.quoteRegex | |||
| ).exec(stdout); | |||
| const permissions = [...stdout.matchAll(/uses-permission: name='(.*)'/g)]; | |||
| const permissions = [...stdout.matchAll(/uses-permission: name='(.+)?' maxSdkVersion='(\d\d)'|uses-permission: name='(.+)'/g)]; | |||
There was a problem hiding this comment.
name='(.+)?'
Won't the ? serve to make the characters between the '' optional? To make this match stingy, I think it should be name='(.+?)'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.android.com/guide/topics/manifest/uses-permission-element
Client should avoid taking a long term dependency on this format.
Updates #193