This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 930
Use BigInt JSON serialization in Solana RPC Subscriptions #3455
Merged
lorisleiva
merged 1 commit into
master
from
loris/use-bigint-json-serialization-in-rpc-subscriptions
Oct 27, 2024
Merged
Use BigInt JSON serialization in Solana RPC Subscriptions #3455
lorisleiva
merged 1 commit into
master
from
loris/use-bigint-json-serialization-in-rpc-subscriptions
Oct 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5710b14 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 25, 2024
This was referenced Oct 25, 2024
mcintyre94
approved these changes
Oct 25, 2024
steveluscher
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
284f666
to
5710b14
Compare
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers a new
createDefaultSolanaRpcSubscriptionsChannelCreator
function that works similarly tocreateDefaultRpcSubscriptionsChannelCreator
but with some Solana-specific defaults.Namely, it uses the brand new
getRpcSubscriptionsChannelWithBigIntJSONSerialization
function to stringify and parse messages to and from the server.