Add ReadonlyUint8Array to codecs + allow decoding from it

[mcintyre94]

This PR adds the proposed ReadonlyUint8Array type to codecs-core. The Decoder interface is modified to allow decoding from a ReadonlyUint8Array | Uint8Array. This will allow us to use ReadonlyUint8Array for various byte encodings, while still being able to decode them as normal byte arrays.

The only place where I needed to add an extra copy is in reverseCodec, which was reversing the input bytes in place. It now creates and reverses a new Uint8Array from the input bytes.

Addresses #2362.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6d5b8ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[mcintyre94]

• add a new ITransactionWithSignatures and IFullySignedTransaction type #2387
• Use readonly uint8array for sign input #2390
• Encode to ReadonlyUint8Array in codecs #2392
• Add ReadonlyUint8Array to codecs + allow decoding from it #2391 👈
• Add support for compiling a TransactionMessage to a new Transaction type #2389
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mcintyre94 and the rest of your teammates on Graphite

[lorisleiva]

I'm pretty amazed that this is all that's required on the codecs side to support ReadonlyUint8Arrays. Thanks!

[steveluscher]

[github-actions]

🎉 This PR is included in version 1.91.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.