This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
The request coalescer now throws the AbortSignal's reason
#2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
steveluscher
force-pushed
the
02-24-Eliminate_jest-fetch-mock-fork_
branch
from
8b39005 to
ce9d0f3
Compare
steveluscher
force-pushed
the
02-24-The_request_coalescer_now_throws_the_AbortSignal_s_reason_
branch
from
a1db3c6 to
148902b
Compare
steveluscher
force-pushed
the
02-24-Eliminate_jest-fetch-mock-fork_
branch
from
ce9d0f3 to
87662a3
Compare
steveluscher
force-pushed
the
02-24-The_request_coalescer_now_throws_the_AbortSignal_s_reason_
branch
from
148902b to
b19be46
Compare
Base automatically changed from
02-24-Eliminate_jest-fetch-mock-fork_
to
master
February 24, 2024 07:42
steveluscher
force-pushed
the
02-24-The_request_coalescer_now_throws_the_AbortSignal_s_reason_
branch
from
b19be46 to
30e573a
Compare
lorisleiva
approved these changes
Feb 27, 2024
| @@ -8,6 +8,13 @@ type CoalescedRequest = { | |||
|
|
|||
| type GetDeduplicationKeyFn = (payload: unknown) => string | undefined; | |||
|
|
|||
| const EXPLICIT_ABORT_TOKEN = Symbol( | |||
There was a problem hiding this comment.
Should we make this a SolanaError instead? I'm a bit scared of global Symbols because of dual package hazards.
There was a problem hiding this comment.
This is fully internal to this module. I throw it through the internal AbortController that's attached to the internal fetch.
steveluscher
deleted the
02-24-The_request_coalescer_now_throws_the_AbortSignal_s_reason_
branch
|
🎉 This PR is included in version 1.90.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I learned today that it's wrong to synthesize an
AbortErrorDOMExceptionwith anAbortSignal'sreason. You should throw thereasondirectly.See https://fetch.spec.whatwg.org/#deserialize-a-serialized-abort-reason