This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
refactor(experimental): graphql: program accounts makeover #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2024
This was referenced Feb 5, 2024
steveluscher
reviewed
Feb 6, 2024
Comment on lines
58
to
66
| await Promise.all( | ||
| Object.values(programAccountsFetchesByArgsHash).map(({ args, fetches: programAddressCallbacks }) => { | ||
| return Object.entries(programAddressCallbacks).map(([programAddress, { callbacks }]) => { |
There was a problem hiding this comment.
Yeah, doubly sorry for leading you astray earlier. These, in the finally block, can all just be .forEach with no returns or awaits. You just need to kick the requests off synchronously and hand them the resolve/reject methods.
steveluscher
approved these changes
Feb 6, 2024
buffalojoec
force-pushed
the
01-23-refactor_experimental_graphql_expand_on_batch_loader_for_accounts
branch
from
a7a244e to
6e871e4
Compare
buffalojoec
force-pushed
the
02-03-refactor_experimental_graphql_program_accounts_makeover
branch
from
516a405 to
2ec3e9a
Compare
buffalojoec
force-pushed
the
01-23-refactor_experimental_graphql_expand_on_batch_loader_for_accounts
branch
from
6e871e4 to
5633432
Compare
buffalojoec
force-pushed
the
02-03-refactor_experimental_graphql_program_accounts_makeover
branch
from
2ec3e9a to
9df3f8b
Compare
steveluscher
approved these changes
Feb 21, 2024
buffalojoec
force-pushed
the
01-23-refactor_experimental_graphql_expand_on_batch_loader_for_accounts
branch
2 times, most recently
from
024daa2 to
6dc0483
Compare
buffalojoec
force-pushed
the
02-03-refactor_experimental_graphql_program_accounts_makeover
branch
from
9df3f8b to
b916bc0
Compare
Merge activity
|
buffalojoec
force-pushed
the
01-23-refactor_experimental_graphql_expand_on_batch_loader_for_accounts
branch
from
6dc0483 to
12fe4ff
Compare
Base automatically changed from
01-23-refactor_experimental_graphql_expand_on_batch_loader_for_accounts
to
master
February 22, 2024 21:04
buffalojoec
force-pushed
the
02-03-refactor_experimental_graphql_program_accounts_makeover
branch
from
b916bc0 to
143d314
Compare
buffalojoec
deleted the
02-03-refactor_experimental_graphql_program_accounts_makeover
branch
|
🎉 This PR is included in version 1.90.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue in the spirit of the previous commit, this time adding a request
coalescer to the
programAccountsquery, allowing for similar optimizations toaccount, despite there being no batch RPC method forgetProgramAccounts.