Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

refactor(experimental): use GraphQL lang for schema #1819

Merged

Conversation

buffalojoec
Copy link
Contributor

This PR is a complete makeover of how this library is using GraphQL.js.

This change pulls in @graphql-tools/schema to build GraphQL type definitions
from actual GraphQL language syntax.

You can see this in action in any of the schema files, such as:

  • src/schema/account.ts
  • src/schema/common/inputs.ts
  • src/schema/transaction.ts

Overall this code is much more readable, easier to organize and keep track of,
and easier to tree-shake.

The library's codebase will scale much easier with this layout.

@mergify mergify bot added the community label Nov 9, 2023
@mergify mergify bot requested a review from a team November 9, 2023 20:23
@buffalojoec buffalojoec force-pushed the 11-09-refactor_experimental_revise_transactions_schema branch from 0e9014b to 1b5ebd6 Compare November 10, 2023 13:33
@buffalojoec buffalojoec force-pushed the 11-09-refactor_experimental_use_GraphQL_lang_for_schema branch from 4671792 to b1e7630 Compare November 10, 2023 13:33
@buffalojoec buffalojoec force-pushed the 11-09-refactor_experimental_use_GraphQL_lang_for_schema branch from b1e7630 to 970a3e3 Compare November 11, 2023 12:44
@buffalojoec buffalojoec marked this pull request as ready for review November 11, 2023 12:52
@buffalojoec buffalojoec force-pushed the 11-09-refactor_experimental_use_GraphQL_lang_for_schema branch from 970a3e3 to 38b2d60 Compare November 11, 2023 14:02
@buffalojoec buffalojoec force-pushed the 11-09-refactor_experimental_revise_transactions_schema branch from 1b5ebd6 to a43b704 Compare November 11, 2023 20:23
@buffalojoec buffalojoec force-pushed the 11-09-refactor_experimental_use_GraphQL_lang_for_schema branch from 38b2d60 to 5850a85 Compare November 11, 2023 20:23
Copy link
Contributor Author

buffalojoec commented Nov 11, 2023

Merge activity

  • Nov 11, 3:24 PM: @buffalojoec started a stack merge that includes this pull request via Graphite.
  • Nov 11, 3:25 PM: Graphite rebased this pull request as part of a merge.
  • Nov 11, 3:25 PM: @buffalojoec merged this pull request with Graphite.

Base automatically changed from 11-09-refactor_experimental_revise_transactions_schema to master November 11, 2023 20:24
@buffalojoec buffalojoec force-pushed the 11-09-refactor_experimental_use_GraphQL_lang_for_schema branch from 5850a85 to d10371e Compare November 11, 2023 20:25
@buffalojoec buffalojoec merged commit cc94aa3 into master Nov 11, 2023
5 of 6 checks passed
@buffalojoec buffalojoec deleted the 11-09-refactor_experimental_use_GraphQL_lang_for_schema branch November 11, 2023 20:25
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant