This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 923
refactor(experimental): use GraphQL lang for schema #1819
Merged
buffalojoec
merged 1 commit into
master
from
11-09-refactor_experimental_use_GraphQL_lang_for_schema
Nov 11, 2023
Merged
refactor(experimental): use GraphQL lang for schema #1819
buffalojoec
merged 1 commit into
master
from
11-09-refactor_experimental_use_GraphQL_lang_for_schema
Nov 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
buffalojoec
force-pushed
the
11-09-refactor_experimental_revise_transactions_schema
branch
from
November 10, 2023 13:33
0e9014b
to
1b5ebd6
Compare
buffalojoec
force-pushed
the
11-09-refactor_experimental_use_GraphQL_lang_for_schema
branch
from
November 10, 2023 13:33
4671792
to
b1e7630
Compare
buffalojoec
force-pushed
the
11-09-refactor_experimental_use_GraphQL_lang_for_schema
branch
from
November 11, 2023 12:44
b1e7630
to
970a3e3
Compare
This was referenced Nov 11, 2023
buffalojoec
force-pushed
the
11-09-refactor_experimental_use_GraphQL_lang_for_schema
branch
from
November 11, 2023 14:02
970a3e3
to
38b2d60
Compare
buffalojoec
force-pushed
the
11-09-refactor_experimental_revise_transactions_schema
branch
from
November 11, 2023 20:23
1b5ebd6
to
a43b704
Compare
buffalojoec
force-pushed
the
11-09-refactor_experimental_use_GraphQL_lang_for_schema
branch
from
November 11, 2023 20:23
38b2d60
to
5850a85
Compare
Merge activity
|
Base automatically changed from
11-09-refactor_experimental_revise_transactions_schema
to
master
November 11, 2023 20:24
buffalojoec
force-pushed
the
11-09-refactor_experimental_use_GraphQL_lang_for_schema
branch
from
November 11, 2023 20:25
5850a85
to
d10371e
Compare
buffalojoec
deleted the
11-09-refactor_experimental_use_GraphQL_lang_for_schema
branch
November 11, 2023 20:25
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a complete makeover of how this library is using GraphQL.js.
This change pulls in
@graphql-tools/schema
to build GraphQL type definitionsfrom actual GraphQL language syntax.
You can see this in action in any of the schema files, such as:
src/schema/account.ts
src/schema/common/inputs.ts
src/schema/transaction.ts
Overall this code is much more readable, easier to organize and keep track of,
and easier to tree-shake.
The library's codebase will scale much easier with this layout.