Chore/sign message clarificaitons #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfrosty
requested changes
Oct 2, 2024
There was a problem hiding this comment.
thanks for addressing all of this @tsmbl! just a few minor nits/typo fixes
| @@ -29,7 +29,7 @@ export interface CreateActionPostResponseArgs< | |||
| TransactionType = Transaction | VersionedTransaction, | |||
| > { | |||
| /** POST response fields per the Solana Actions spec. */ | |||
| fields: Omit<ActionPostResponse, "transaction"> & { | |||
| fields: Omit<TransactionResponse, "transaction"> & { | |||
There was a problem hiding this comment.
this works for now since the createPostResponse does not yet support the recently added optional transactions and external links are not supported at all in the current version of @solana/actions
either way, this will also require updating the spec package inside the @solana/actions package.
I just opened an issue to track it and will complete the update in a different PR: #34
There was a problem hiding this comment.
agreed, just wanted to address existing build errors
thanks for creating the issue
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
Co-authored-by: Nick Frostbutter <[email protected]>
nickfrosty
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update readme with clarifications on
SignMessagedata formatting, inspired by https://github.com/phantom/sign-in-with-solana, butchore: