Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aarch64 with pip #639

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Support aarch64 with pip #639

merged 2 commits into from
Jul 22, 2024

Conversation

wahabk
Copy link
Contributor

@wahabk wahabk commented Jul 22, 2024

This is a minimal PR changing tensorflow-cpu -> tensorflow in pyproject.toml as Tensorflow does not build wheels of tensorflow-cpu for Arm.

See #637 for more details.

@milot-mirdita Do you think there is a better way to overcome thi?

@milot-mirdita
Copy link
Collaborator

Could you try if:

tensorflow-cpu = { version = "^2.12.1", markers = "sys_platform != 'darwin' and platform_machine != 'arm64'" }
tensorflow = { version = "^2.12.1", markers = "sys_platform != 'darwin' and platform_machine == 'arm64'" }

works?
We want to use tensorflow-cpu whenever possible

@wahabk
Copy link
Contributor Author

wahabk commented Jul 22, 2024

Great idea!

tensorflow-cpu = { version = "^2.12.1", markers = "sys_platform != 'darwin' and platform_machine != 'aarch64'" }
tensorflow = { version = "^2.12.1", markers = "sys_platform != 'darwin' and platform_machine == 'aarch64'" }

This works when specifying aarch64 instead of arm64.

I just pushed a new commit. Happy for this to be merged.

@milot-mirdita milot-mirdita merged commit 1ccca5a into sokrypton:main Jul 22, 2024
@milot-mirdita
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants