feat(ohos): fix HippyCustomComponentView position

sohotz · Sep 25, 2024 · 914e55c · 914e55c
1 parent 51a22a6
commit 914e55c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 26 deletions.
diff --git a/framework/examples/ohos-demo/src/main/ets/hippy_extend/ExampleViewA.ets b/framework/examples/ohos-demo/src/main/ets/hippy_extend/ExampleViewA.ets
@@ -37,19 +37,6 @@ export class ExampleViewA extends HippyCustomComponentView {
     return super.setProp(propKey, propValue)
   }
 
-  updateRenderViewFrame(frame: HRRect, padding: HRPadding | null): void {
-    // For c api, the position is used by container node.
-    if (this.ctx.getNativeRender().isEnableArkCApi()) {
-      this.cssPositionX = 0
-      this.cssPositionY = 0
-    } else {
-      this.cssPositionX = frame.x
-      this.cssPositionY = frame.y
-    }
-    this.cssWidth = frame.width
-    this.cssHeight = frame.height
-  }
-
   call(method: string, params: Array<HippyAny>, callback: HippyRenderCallback | null): void {
 
   }

diff --git a/framework/examples/ohos-demo/src/main/ets/hippy_extend/ExampleViewB.ets b/framework/examples/ohos-demo/src/main/ets/hippy_extend/ExampleViewB.ets
@@ -37,19 +37,6 @@ export class ExampleViewB extends HippyCustomComponentView {
     return super.setProp(propKey, propValue)
   }
 
-  updateRenderViewFrame(frame: HRRect, padding: HRPadding | null): void {
-    // For c api, the position is used by container node.
-    if (this.ctx.getNativeRender().isEnableArkCApi()) {
-      this.cssPositionX = 0
-      this.cssPositionY = 0
-    } else {
-      this.cssPositionX = frame.x
-      this.cssPositionY = frame.y
-    }
-    this.cssWidth = frame.width
-    this.cssHeight = frame.height
-  }
-
   call(method: string, params: Array<HippyAny>, callback: HippyRenderCallback | null): void {
 
   }

diff --git a/framework/ohos/src/main/ets/renderer_native/components/custom/HippyCustomComponentView.ets b/framework/ohos/src/main/ets/renderer_native/components/custom/HippyCustomComponentView.ets
@@ -20,6 +20,7 @@
 import { HippyAny, HippyRenderCallback } from '../../../support/common/HippyTypes'
 import { NativeRenderContext } from '../../NativeRenderContext'
 import { HRMeasureMode, HRMeasureResult } from '../../utils/HRMeasure'
+import { HRPadding, HRRect } from '../../utils/HRTypes'
 import HippyRenderBaseView from '../base/HippyRenderBaseView'
 
 export class HippyCustomComponentView extends HippyRenderBaseView {
@@ -31,6 +32,19 @@ export class HippyCustomComponentView extends HippyRenderBaseView {
     return super.setProp(propKey, propValue)
   }
 
+  updateRenderViewFrame(frame: HRRect, padding: HRPadding | null): void {
+    // For c api, the position is used by container node.
+    if (this.ctx.getNativeRender().isEnableArkCApi()) {
+      this.cssPositionX = 0
+      this.cssPositionY = 0
+    } else {
+      this.cssPositionX = frame.x
+      this.cssPositionY = frame.y
+    }
+    this.cssWidth = frame.width
+    this.cssHeight = frame.height
+  }
+
   call(method: string, params: Array<HippyAny>, callback: HippyRenderCallback | null): void {
 
   }