MPT-5146 support price list vendor external ID #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-sebrango
requested review from
d3rky,
ffaraone,
robcsegal and
bpolgar-swo
and removed request for
d3rky
d3rky
requested changes
Jan 13, 2025
swo/mpt/cli/core/pricelists/flows.py
Outdated
| } | ||
|
|
||
| external_id = find_value_for(constants.EXTERNAL_ID, values)[2] \ |
There was a problem hiding this comment.
I would simplify here a little bit
external_id_value = find_value_for(...)
external_id = external_id_value[2] if external_id_value else None
ruben-sebrango
force-pushed
the
MPT-5146-adobe-vipm-global-customers-cli-tool-support-price-list-external-id
branch
from
b93e120 to
5d4de5c
Compare
|
d3rky
approved these changes
Jan 13, 2025
d3rky
deleted the
MPT-5146-adobe-vipm-global-customers-cli-tool-support-price-list-external-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.