Merge pull request #37 from softwareone-platform/bugfix/MPT-3586/fix-…

…items-api-changes MPT-3586 Do not pass commitment period for one-time items
softwareone-platform · Oct 10, 2024 · c247be4 · c247be4
2 parents c0f3c6a + ed425ef
commit c247be4
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/swo/mpt/cli/core/products/flows.py b/swo/mpt/cli/core/products/flows.py
@@ -333,16 +333,24 @@ def _to_item_json(
             constants.ITEMS_QUANTITY_APPLICABLE, values
         )[2]
         == "True",
-        "terms": {
-            "commitment": find_value_for(constants.ITEMS_COMMITMENT_TERM, values)[2],
-            "period": find_value_for(constants.ITEMS_BILLING_FREQUENCY, values)[2],
-        },
         "unit": {
             "id": find_value_for(constants.ITEMS_UNIT_ID, values)[2],
         },
         "parameters": parameters,
     }
 
+    period = find_value_for(constants.ITEMS_BILLING_FREQUENCY, values)[2]
+
+    if period == "one-time":
+        item_json["terms"] = {
+            "period": period,
+        }
+    else:
+        item_json["terms"] = {
+            "commitment": find_value_for(constants.ITEMS_COMMITMENT_TERM, values)[2],
+            "period": period,
+        }
+
     if is_operations:
         item_json["externalIds"] = {
             "operations": find_value_for(constants.ITEMS_ERP_ITEM_ID, values)[2]