Finer grained logging #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK for me to rebase? |
snare previously had a simple notion of logging: either it's an error, and reported, or it isn't. This commit paves the way for a finer-grained notion of logging. Adds a `-v` switch (which can be repeated for greater levels of verbosity).
Some of the logging information in snare tells the user they've misconfigured snare or GitHub, but some logging information is really meant to help someone debug a change in GitHub requests. This commit teases those two out. By making HTTP request functions take `TcpStream` (i.e. moving it) the terminal part of this function is now a little harder to misuse, and also allows us to restore more informative HTTP return codes (e.g. "unauthorised").
|
Go ahead. |
ltratt
force-pushed
the
finer_grained_logging
branch
from
f8e47be to
119a176
Compare
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #128 to be merged first.
This PR moves snare to a more fine-grained logging framework, and then makes use of that finer-grained logging to avoid bombarding the user with irrelevant stuff in the common case. For example, before this PR, invalid HTTP requests (caused, almost certainly, by spammers) generated logging, which isn't very useful. After this PR one only sees that if
-vvvvis specified. At the default level of verbosity, however, more genuine errors (e.g. requests that don't authenticate) are logged.