Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial File Pickers: 'showOpenFilePicker', 'showSaveFilePicker', 'showDirectoryPicker' #765

Merged
merged 16 commits into from
Nov 16, 2023
Merged

Initial File Pickers: 'showOpenFilePicker', 'showSaveFilePicker', 'showDirectoryPicker' #765

merged 16 commits into from
Nov 16, 2023

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Nov 11, 2023 •
edited
Loading

This PR introduces support for global showOpenFilePicker(), showSaveFilePicker(), and showDirectoryPicker() functions backed by SSC::Dialog and the JavaScript runtime socket:fs module. This PR provides native support for File, FileSystemHandle, FileSystemFileHandle, FileSystemDirectoryHandle, and FileSystemWritableFileStream interfaces returned by the picker functions.

APIs

  • showOpenFilePicker
  • showSaveFilePicker
  • showDirectoryPicker

Platforms

  • Android
  • iOS
  • Linux
  • macOS
  • Windows

@jwerle jwerle added enhancement New feature or request javascript An issue, discussion, or task related to the runtime javascript api An issue, task, or discussion related to public runtime APIs runtime An issue, task, or discussion related to the runtime core labels Nov 11, 2023
@jwerle jwerle self-assigned this Nov 11, 2023
@chicoxyzzy
Copy link
Member

chicoxyzzy commented Nov 13, 2023 •
edited
Loading

Let's enable getScreenSize and getWindows tests for iOS in test/src/application.js!

@jwerle jwerle force-pushed the initial-internal-pickers branch from 747fe93 to a413b29 Compare November 15, 2023 00:15
@jwerle jwerle force-pushed the initial-internal-pickers branch from 9e2d1c2 to 5e78a66 Compare November 15, 2023 23:24
@jwerle jwerle added windows android linux An issue, task, or pull request related to linux ios An issue, task, or pull request related to iOS macos An issue, task, or discussion related to macOS labels Nov 15, 2023
@jwerle jwerle requested review from bcomnes and heapwolf November 16, 2023 01:43
@jwerle jwerle requested a review from chicoxyzzy November 16, 2023 01:43
@jwerle jwerle marked this pull request as ready for review November 16, 2023 01:43
@jwerle jwerle merged commit 4000aad into master Nov 16, 2023
@jwerle jwerle deleted the initial-internal-pickers branch November 16, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcomnes bcomnes bcomnes approved these changes

@chicoxyzzy chicoxyzzy chicoxyzzy approved these changes

@heapwolf heapwolf Awaiting requested review from heapwolf

Assignees

@jwerle jwerle

Labels
android api An issue, task, or discussion related to public runtime APIs enhancement New feature or request ios An issue, task, or pull request related to iOS javascript An issue, discussion, or task related to the runtime javascript linux An issue, task, or pull request related to linux macos An issue, task, or discussion related to macOS runtime An issue, task, or discussion related to the runtime core windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwerle @chicoxyzzy @bcomnes