Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test ordering #731

Closed
wants to merge 1 commit into from
Closed

Fix test ordering #731

wants to merge 1 commit into from

Conversation

bcomnes
Copy link
Contributor

@bcomnes bcomnes commented Oct 27, 2023

When you import a tests, they can run out of expected order. This guarantees that tests run in order.

Short term fix until we have built in test globbig/loading.

When you import a tests, they can run out of expected order. This guarantees that tests run in order.

Short term fix until we have built in test globbig/loading.
@bcomnes bcomnes force-pushed the bret/fix-test-loadoing branch from 4be8a63 to 61b1cf9 Compare October 27, 2023 23:19
@jwerle
Copy link
Member

jwerle commented Oct 28, 2023

await import() will break tests for widow.onload as now ESM is async.

@bcomnes
Copy link
Contributor Author

bcomnes commented Oct 28, 2023

Arg you're right.

@bcomnes bcomnes closed this Oct 28, 2023
@bcomnes bcomnes deleted the bret/fix-test-loadoing branch October 28, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants