Add a recursive option to mkdir #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicoxyzzy
reviewed
Oct 26, 2023
bcomnes
force-pushed
the
bret/recursive-mkdirp
branch
from
001c7e1 to
c209d34
Compare
jwerle
reviewed
Oct 27, 2023
jwerle
reviewed
Oct 27, 2023
jwerle
reviewed
Oct 27, 2023
bcomnes
force-pushed
the
bret/recursive-mkdirp
branch
2 times, most recently
from
ca9f271 to
eb868d5
Compare
chicoxyzzy
reviewed
Oct 30, 2023
bcomnes
force-pushed
the
bret/recursive-mkdirp
branch
from
2fa0214 to
155c91d
Compare
chicoxyzzy
reviewed
Oct 30, 2023
I really will need a second pair of eyes here.
This reverts commit 24627b6.
bcomnes
force-pushed
the
bret/recursive-mkdirp
branch
from
48e06a3 to
4a87361
Compare
bcomnes
force-pushed
the
bret/recursive-mkdirp
branch
from
6d66880 to
beb332a
Compare
bcomnes
commented
Oct 31, 2023
|
Ok, I think this should be good to go. |
chicoxyzzy
approved these changes
Nov 1, 2023
|
Looking at CI failures a little closer. |
jwerle
approved these changes
Nov 1, 2023
|
The recursive tests are passing now. The fs.writeFile isn't working on master so I'll merge this now. |
jwerle
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a recursive option to mkdir.
Closes #714