Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Campaign form setup #962

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

andrashee
Copy link
Contributor

Before doing the form itself, I want to quickly check with you @mkue, if the proposed architecture of the page fits into the overall one.
Idea:

  • Static page /campaign to create a new one. Will contain the explanations, FAQ, ...).
  • Client component for the form itself. Directly posts the data to firestore.

Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
public ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 11:41am

Copy link

coderabbitai bot commented Dec 1, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Dec 1, 2024

Visit the preview URL for this PR (updated for commit b2efe59):

https://si-admin-staging--pr962-ahee-campaign-form-s-f0jz5bwb.web.app

(expires Sun, 08 Dec 2024 11:44:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676

@ssandino
Copy link
Member

ssandino commented Dec 2, 2024

Just a hint @andrashee : To make it easier for you, you can simply use the standard “hero” code we use on other pages (see how it looks, and find the code here). This ensures the page has styled basic content and looks decent from the start, allowing us to publish now and optimize later.

Screenshot 2024-12-02 at 11 49 29

Text proposition:

Big or Small, Every Fundraiser Counts
Every effort brings us closer to a world where everyone can live with dignity.
(Button)

Translations:

Ob gross oder klein, jede Spendenaktion zählt
Jeder Beitrag bringt uns einer Welt näher, in der alle in Würde leben können.

French (FR):
Grande ou petite, chaque collecte compte
Chaque effort nous rapproche d’un monde où chacun peut vivre dans la dignité.

Italian (IT):
Grande o piccolo, ogni raccolta fondi conta
Ogni sforzo ci avvicina a un mondo in cui tutti possano vivere con dignità.

PS. I assume this page will later also display public fundraisers, which could be shown using the standardized cards we use on the partners page. This is for a later stage, but I wanted to mention it early to avoid anyone spending time creating a separate card design.

@mkue
Copy link
Contributor

mkue commented Dec 3, 2024

Before doing the form itself, I want to quickly check with you @mkue, if the proposed architecture of the page fits into the overall one. Idea:

  • Static page /campaign to create a new one. Will contain the explanations, FAQ, ...).
  • Client component for the form itself. Directly posts the data to firestore.

Yes, that definitely makes sense. I like that you used the useMutation() hook, I wanted to start using that also :)

How do we ensure that people can only edit their pages? I guess we need a security rule that checks if the edit request matches the email of the creator. I wonder though if the email is a good identifier for that because if someone changes their email they will never be able to edit their campaign. Maybe we should also store the auth_user_id of the creator on the campaign object to unambiguously identify the user?

Base automatically changed from ahee/campaign-extract-translations to main December 10, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants