-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website: Campaign form setup #962
base: main
Are you sure you want to change the base?
Conversation
…form-setup # Conflicts: # shared/locales/de/website-campaign.json
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Visit the preview URL for this PR (updated for commit b2efe59): https://si-admin-staging--pr962-ahee-campaign-form-s-f0jz5bwb.web.app (expires Sun, 08 Dec 2024 11:44:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676 |
Just a hint @andrashee : To make it easier for you, you can simply use the standard “hero” code we use on other pages (see how it looks, and find the code here). This ensures the page has styled basic content and looks decent from the start, allowing us to publish now and optimize later. Text proposition:Big or Small, Every Fundraiser Counts Translations:Ob gross oder klein, jede Spendenaktion zählt French (FR): Italian (IT): PS. I assume this page will later also display public fundraisers, which could be shown using the standardized cards we use on the partners page. This is for a later stage, but I wanted to mention it early to avoid anyone spending time creating a separate card design. |
Yes, that definitely makes sense. I like that you used the How do we ensure that people can only edit their pages? I guess we need a security rule that checks if the edit request matches the email of the creator. I wonder though if the email is a good identifier for that because if someone changes their email they will never be able to edit their campaign. Maybe we should also store the |
Before doing the form itself, I want to quickly check with you @mkue, if the proposed architecture of the page fits into the overall one.
Idea: