Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (iac): update project page link for iac v2 --report #5702

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

alina-d-m
Copy link
Contributor

@alina-d-m alina-d-m commented Jan 30, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

This PR is related to the IaC V2 product (i.e. iacNewEngine feature flag).
Based on the project public id received from snyk-iac-test when the --report option is used, show the correct link (Snyk UI) to the project results. If the project is not created properly, show an error message.

Where should the reviewer start?

How should this be manually tested?

Make sure to have the iacNewEngine feature flag.
Run the snyk iac test --report command using the corresponding snyk-iac-test version (https://github.com/snyk/snyk-iac-test/pull/264).
The output should include a link to the specific project for which the results are reported.

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/iac/test/v2/output.ts
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 1c9b3b3

@alina-d-m alina-d-m changed the title fix: draft [IAC-3180] fix: show correct link to project page for iacNewEngine --report [IAC-3180] Jan 30, 2025
@alina-d-m alina-d-m changed the title fix: show correct link to project page for iacNewEngine --report [IAC-3180] fix (iac): update project page link for iac v2 --report Jan 30, 2025
@alina-d-m alina-d-m force-pushed the fix/IAC-3180/fix-iac-v2-link-to-results branch from 508bb78 to 66c6ae9 Compare February 4, 2025 09:17
@alina-d-m alina-d-m force-pushed the fix/IAC-3180/fix-iac-v2-link-to-results branch 3 times, most recently from 68adb7f to 78c0ec7 Compare February 4, 2025 13:22
@alina-d-m alina-d-m marked this pull request as ready for review February 5, 2025 08:30
@alina-d-m alina-d-m requested a review from a team as a code owner February 5, 2025 08:30
@alina-d-m alina-d-m force-pushed the fix/IAC-3180/fix-iac-v2-link-to-results branch from 78c0ec7 to 8d5be97 Compare February 5, 2025 08:31
Updates the user messages for snyk iac test --report for IaC V2.
@sandor-trombitas sandor-trombitas force-pushed the fix/IAC-3180/fix-iac-v2-link-to-results branch from 8d5be97 to 1c9b3b3 Compare February 7, 2025 08:12
@sandor-trombitas sandor-trombitas merged commit c1cf770 into main Feb 7, 2025
7 checks passed
@sandor-trombitas sandor-trombitas deleted the fix/IAC-3180/fix-iac-v2-link-to-results branch February 7, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants