Hotfix: Fix overwriting a variable in runner #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunseong
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
runnerfunction inrunner.pyreceivesinstance_idxas a function parameter, for creating Signal objects to pass over to the next step.Unfortunately, the latest PR #58 added an error of overwriting that parameter with a variable (of the same name) that has a completely different purpose. This bug wasn't observed in that PR because the test case did not actually involve any runner step that handles both shared input and output tensors. Rather, I tripped over this when I was working on #44, which adds a final aggregator step and thus uncovers this hidden error.
I've solved this simply by giving the corresponding variable a different name.