[JS-13] Copy global model when accessing it from local tablet #14
Conversation
| @@ -293,7 +296,7 @@ public void putIfAbsentNoReply(final K key, @Nonnull final V value) { | |||
| remoteIdOptional = remoteIdWithLock.getKey(); | |||
| try { | |||
| // execute operation in local | |||
| if (!remoteIdOptional.isPresent()) { | |||
| if (!copy && !remoteIdOptional.isPresent()) { | |||
There was a problem hiding this comment.
Could you help me understand how values are copied when copy is true? Is it enough to put the request to a queue for handling remote operations?
There was a problem hiding this comment.
They're copied through encoding and decoding.
There was a problem hiding this comment.
And the operation should go into the queue not to get undetermined states by concurrent updates.
There was a problem hiding this comment.
This way of copying have unnecessary overhead.
Issue #11.
There was a problem hiding this comment.
Thanks for the explanation. It looks working well; we may have to keep an eye on #11, though.
I will merge it.
| @@ -293,7 +296,7 @@ public void putIfAbsentNoReply(final K key, @Nonnull final V value) { | |||
| remoteIdOptional = remoteIdWithLock.getKey(); | |||
| try { | |||
| // execute operation in local | |||
| if (!remoteIdOptional.isPresent()) { | |||
| if (!copy && !remoteIdOptional.isPresent()) { | |||
There was a problem hiding this comment.
Thanks for the explanation. It looks working well; we may have to keep an eye on #11, though.
I will merge it.
Resolves #13
This PR
copyis settrue, ET puts the operation to the queue that handles remote operations, where values are serialized & deserialized (a performance issue may arise as described in Optimize local access routine of update and get operation #11).