Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush events only when the buffer is full (close #827) #833

Conversation

danigutierrezayuso
Copy link
Contributor

No description provided.

@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@snowplowcla snowplowcla added the cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. label Oct 4, 2023
@danigutierrezayuso
Copy link
Contributor Author

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

I signed it!

@snowplowcla
Copy link

Confirmed! @danigutierrezayuso has signed the Contributor License Agreement. Thanks so much.

@snowplowcla snowplowcla added cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. and removed cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. labels Oct 4, 2023
@matus-tomlein
Copy link
Contributor

Thank you for the contribution @danigutierrezayuso! This is definitely a needed change, but if you don't mind, we'll keep this open for a while longer because we plan to review the emitter behaviour for v6 of the tracker and just want to get the full picture of what needs to change before we merge this in.

@matus-tomlein
Copy link
Contributor

Thanks again for the contribution @danigutierrezayuso! I have cherry picked the commit into another PR #850 where we will review it along with some other changes in the emitter behaviour and get this out in the v6 release of the tracker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants