-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snowflake lake loader support #59
Merged
rlh1994
merged 6 commits into
release/snowplow-unified/0.4.4
from
feature/support-snowflake-lake
Jun 25, 2024
Merged
Add snowflake lake loader support #59
rlh1994
merged 6 commits into
release/snowplow-unified/0.4.4
from
feature/support-snowflake-lake
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeemster
reviewed
Jun 25, 2024
jbeemster
reviewed
Jun 25, 2024
063a92f
to
a3f6b57
Compare
agnessnowplow
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, considering the testing limitations and the method to convert the cases automatically, it "should" be ok. Keeping in mind the urgency I am fine to get this live with the caveat sentence in the release notes that it is still in a sort of POC state.
rlh1994
added a commit
that referenced
this pull request
Jun 26, 2024
* Make changes for snowflake lake loader support * hard-cast fields * reset project file * lake loader isn't on by default * Add note about lake loader workaround * fix falses
rlh1994
added a commit
that referenced
this pull request
Jun 26, 2024
* Make changes for snowflake lake loader support * hard-cast fields * reset project file * lake loader isn't on by default * Add note about lake loader workaround * fix falses
jedichien
pushed a commit
to viki-org/dbt-snowplow-unified
that referenced
this pull request
Jul 2, 2024
* Make changes for snowflake lake loader support * hard-cast fields * reset project file * lake loader isn't on by default * Add note about lake loader workaround * fix falses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR in theory adds the ability to run snowflake on a lake loader external (iceberg) table. Currently it does not work because you can't write structured columns to a regular table, and dbt-snowflake doesn't yet support writing to iceberg. In theory it would work, but short of casting every single field within a context and unstruct to a varchar and back again, I am currently not able to test it.
I've worked around this similar to how we do in web with redshift not having a "* except" feature, by getting all columns from the CTE and then casting them all individually. This feels non-ideal, but at least in my basic testing does seem to allow the models to run at least.
I would suggest:
What type of PR is this? (check all applicable)
Related Tickets & Documents
https://snplow.atlassian.net/browse/PE-6472
Checklist
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?