Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

add git branching model #15

Merged
merged 1 commit into from
Feb 10, 2020
Merged

add git branching model #15

merged 1 commit into from
Feb 10, 2020

Conversation

peel
Copy link
Contributor

@peel peel commented Feb 10, 2020 •
edited
Loading

A brief overview to be a quick reminder what's what in gitflow an links to more elaborate resources
Source: https://snowplow.slack.com/archives/CKG7E50HX/p1581004086209800

Part of snowplow/snowplow#4283 effort

@peel peel mentioned this pull request Feb 10, 2020
Merged
2 tasks
@peel peel requested a review from a team February 10, 2020 11:15
lukeindykiewicz
lukeindykiewicz approved these changes Feb 10, 2020
View reviewed changes
Copy link

@lukeindykiewicz lukeindykiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

git-branching.md Outdated Show resolved Hide resolved
@peel peel force-pushed the feature/git-branching branch from c222402 to db0444b Compare February 10, 2020 11:17
chuwy
chuwy approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@chuwy chuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could you also cross-link it with Style Guide and mention that we use it for beam-enrich now and going to use for scala-common-enrich as an experiment.

@peel
Copy link
Contributor Author

peel commented Feb 10, 2020 •
edited
Loading

@chuwy I'd rather limit number of reasons for change in that file as docs are not going to age well. Please do put that info in #8 that is referenced in first sentence (I made it more visible), so we don't have to change it over time for that reason.

edit: I updated the docs to reflect ☝️

@peel peel force-pushed the feature/git-branching branch 2 times, most recently from 2d71fcd to e73d7f5 Compare February 10, 2020 16:42
@peel peel force-pushed the feature/git-branching branch from e73d7f5 to b33607d Compare February 10, 2020 16:43
@peel peel merged commit a65ae0f into master Feb 10, 2020
@peel peel deleted the feature/git-branching branch February 10, 2020 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chuwy chuwy chuwy approved these changes

@lukeindykiewicz lukeindykiewicz lukeindykiewicz approved these changes

@benjben benjben benjben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peel @chuwy @lukeindykiewicz @benjben