Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up proxy after unit tests #932

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Clean up proxy after unit tests #932

merged 2 commits into from
Jan 29, 2025

Conversation

sfc-gh-alhuang
Copy link
Contributor

The InternalStageTest didn't clean up the proxy after test which cause some Jenkins jobs failed to fetch package afterwards. Clean up proxy to make it work.

@sfc-gh-alhuang sfc-gh-alhuang requested review from sfc-gh-tzhang and a team as code owners January 23, 2025 21:36
@sfc-gh-tzhang
Copy link
Contributor

@sfc-gh-alhuang could you help with investigating the test failure in the merge gate? That seems like a real issue instead of flaky test

Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@sfc-gh-alhuang sfc-gh-alhuang merged commit 7193c5d into master Jan 29, 2025
49 checks passed
@sfc-gh-alhuang sfc-gh-alhuang deleted the alhuang-clear-proxy branch January 29, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants