[GC] Make sure we don't take a GC lock for grow/shrink calls without …

…entering a busy state. (#414)
snazzy-d · Dec 23, 2024 · b0ca296 · b0ca296
1 parent 3b70ab1
commit b0ca296
Showing 1 changed file with 17 additions and 3 deletions.
diff --git a/sdlib/d/gc/tcache.d b/sdlib/d/gc/tcache.d
@@ -303,13 +303,13 @@ public:
 				auto npages = getPageCount(size);
 
 				if (epages < npages) {
-					if (!pd.arena.growLarge(emap, e, npages)) {
+					if (!growLarge(pd, npages)) {
 						goto LargeResizeFailed;
 					}
 
 					triggerAllocationEvent((npages - epages) * PageSize);
 				} else if (epages > npages) {
-					if (!pd.arena.shrinkLarge(emap, e, npages)) {
+					if (!shrinkLarge(pd, npages)) {
 						goto LargeResizeFailed;
 					}
 
@@ -708,7 +708,7 @@ private:
 
 		auto npages = getPageCount(newCapacity);
 		if (epages < npages) {
-			if (!pd.arena.growLarge(emap, e, npages)) {
+			if (!growLarge(pd, npages)) {
 				return false;
 			}
 
@@ -722,6 +722,20 @@ private:
 		return true;
 	}
 
+	bool growLarge(PageDescriptor pd, uint npages) {
+		state.enterBusyState();
+		scope(exit) state.exitBusyState();
+
+		return pd.arena.growLarge(emap, pd.extent, npages);
+	}
+
+	bool shrinkLarge(PageDescriptor pd, uint npages) {
+		state.enterBusyState();
+		scope(exit) state.exitBusyState();
+
+		return pd.arena.shrinkLarge(emap, pd.extent, npages);
+	}
+
 	auto getPageDescriptor(void* ptr) {
 		auto pd = maybeGetPageDescriptor(ptr);
 		assert(pd.extent !is null);