build: use node snap for build #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I first switched this snap to build from source, I couldn't make the process succeed using the node snap, which led to a rather more complicated method for obtaining and configuring nodejs. Taking another look, the issues I was seeing seem to be resolved.
jnsgruk
requested review from
merlijn-sebrechts and
soumyaDghosh
and removed request for
merlijn-sebrechts
|
No, too much complexity in how signal is put together with its different parts, and the patch we apply I think |
|
Going to merge this, since it's a mechanical change which simplifies the build but makes no change to the end product. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first switched this snap to build from source, I couldn't make the process succeed using the node snap, which led to a rather more complicated method for obtaining and configuring nodejs.
Taking another look, the issues I was seeing seem to be resolved.