split smoltcp in smolutils, smolwire and smoltcp #812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thvdveld
changed the title
thvdveld
force-pushed
the
smolwire
branch
3 times, most recently
from
395ee79 to
8f6db63
Compare
Codecov Report
@@ Coverage Diff @@
## main #812 +/- ##
==========================================
- Coverage 79.65% 79.63% -0.03%
==========================================
Files 72 75 +3
Lines 27862 27854 -8
==========================================
- Hits 22193 22181 -12
- Misses 5669 5673 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Going to close this as this would add more maintenance overhead (for the smoltcp team) compared to a single crate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits smoltcp into 3 crates.
smolutils
This contains logic that is shared between smolwire and smoltcp. The logic that is shared is
timeand some parts ofphy, such asChecksumCapabilitiesandMedium. I don't think this crate should be released or something (I'm not sure since I never actually released big crates).smolwire
This crate contains logic for parsing and emitting IP packets. This crate should be released, since this contains useful parsing structures, not only for smoltcp but also for other use cases.
I named it smolwire since the structures were in the wire module. Maybe
smolpacketsis better, as suggested in #811 ?smoltcp
This is the TCP/IP library of smoltcp.
TODO