Submit on FM startup #119
Submit on FM startup #119
Conversation
services/fluxmonitor.go
Outdated
| @@ -179,6 +179,7 @@ func (fm *FluxMonitor) eventListener(ch <-chan interface{}) { | |||
| } | |||
|
|
|||
| func (fm *FluxMonitor) canSubmitToRound(initiate bool) bool { | |||
|
|
|||
services/fluxmonitor.go
Outdated
| @@ -256,6 +257,7 @@ func (fm *FluxMonitor) hitTrigger() { | |||
|
|
|||
| func (fm *FluxMonitor) startPoller() { | |||
| fm.poll() | |||
| fm.checkAndSendJob(false) | |||
There was a problem hiding this comment.
We should probably move this to FM startup and when eligibility to submit changes. Although we haven't gotten that far yet, there will be cases where the poller is disabled - so we can't always rely on this to be triggered.
I'll make a new issue for making the poll interval and heartbeat "optional" - but for now I think we should just move this to the FM startup and when the FA state is updated to make the oracle eligible to submit.
There was a problem hiding this comment.
But if we call it in an earlier state than here, before polling has started(e.g near the 1st call of canSubmitUpdated), we wont't have a result to send, right?
There was a problem hiding this comment.
Right, so that function will see that it doesn't have any recent results and do it's own poll to get the latest median.
services/fluxmonitor.go
Outdated
| if fm.latestResult.IsZero() { | ||
| logger.Warn("Polling because result is zero") | ||
| err := fm.poll() | ||
| if err != nil { | ||
| logger.Error("cannot retrieve result from polling") | ||
| return err | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This shouldn't be necessary, since we're checking the age of the result just below this (L227). If this hasn't been set - it's always going to trigger a new poll.
There was a problem hiding this comment.
True + it will start having an actual functionality :)
ebarakos
force-pushed
the
fm/submit-on-startup
branch
from
91f813e to
0185493
Compare
Regarding #117, how about always sending a job request after first results from polling?