Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown link check #2804

Merged
merged 52 commits into from
Oct 15, 2024
Merged

Fix markdown link check #2804

merged 52 commits into from
Oct 15, 2024

Conversation

Dxuian
Copy link
Contributor

@Dxuian Dxuian commented Oct 11, 2024

regarding #2480

fixes #1862

refs #344

@Dxuian Dxuian marked this pull request as draft October 11, 2024 18:25
@github-actions github-actions bot added the doc label Oct 11, 2024
@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 11, 2024

@johnbampton @BaseMax okay so there's nothing wrong with the link checker the problem seems to be in the fact that the links it tries to check are actually dead or behind a 301, 302, 307, and 308 redirect the solution to this should be removal of dead links and accommodation of redirects

@github-actions github-actions bot added the repo label Oct 11, 2024
@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 11, 2024

403 codes are also present in some links that work

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 11, 2024

i've looked up the GitHub action and looks like there's a alternative to it so i will be trying that one

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 11, 2024

i've looked up the GitHub action and looks like there's a alternative to it so i will be trying that one

looks like the alternative isnt fully built so its better to stick to this

@Dxuian Dxuian marked this pull request as ready for review October 12, 2024 09:41
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 12, 2024
@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 14, 2024

@johnbampton it passes the link test now pls review

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 14, 2024

the test is failing again lemme see

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 14, 2024

since dir exclusion isnt possible i have found a alternative to this action its basically the newer version of the old one so im going to experiment with the new one

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 14, 2024

since dir exclusion isnt possible i have found a alternative to this action its basically the newer version of the old one so im going to experiment with the new one

the tool is still incomplete reverting to old one

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 14, 2024

@johnbampton pls review

@Dxuian Dxuian requested a review from jbampton October 14, 2024 20:03
@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 14, 2024

@johnbampton ive managed to fix pre-commit errs also

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 15, 2024

@johnbampton any changes ?

@BaseMax
Copy link
Member

BaseMax commented Oct 15, 2024

?

@jbampton jbampton merged commit ff1299a into slurpcode:main Oct 15, 2024
31 of 34 checks passed
@Dxuian Dxuian deleted the markdown-failure branch October 16, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Broken links: configure link checker
3 participants