Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Always run CodeQL #1792

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Conversation

ianlewis
Copy link
Member

@ianlewis ianlewis commented Mar 10, 2023

Fixes #1261

Run CodeQL on all PRs. CodeQL actions succeed even if there are errors so our noop setup didn't really work anyway. What we really need is the protected branch check that looks at the resulting "Checks" output that CodeQL uploads.

Signed-off-by: Ian Lewis <[email protected]>
@ianlewis ianlewis changed the title Always run CodeQL chore: Always run CodeQL Mar 10, 2023
@ianlewis ianlewis enabled auto-merge (squash) March 22, 2023 23:54
@ianlewis ianlewis merged commit f1e307f into slsa-framework:main Mar 22, 2023
@ianlewis
Copy link
Member Author

I updated the branch protection checks for main to require CodeQL checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Restore CodeQL to doc-only commits
2 participants