Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add out variance to ApiResult.Failure generic type #81

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

serge-slack
Copy link
Contributor

@serge-slack serge-slack commented Sep 3, 2024

Summary

Add out variance to ApiResult.Failure<E> to make subtypes implementing Failure<Nothing> such as NetworkFailure conform to Failure<*>

Requirements (place an x in each [ ])

Copy link

salesforce-cla bot commented Sep 3, 2024

Thanks for the contribution! Before we can merge this, we need @serge-slack to sign the Salesforce Inc. Contributor License Agreement.

@ZacSweers ZacSweers merged commit 290aae1 into slackhq:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants