Add the default

slack_cli_hooks/hooks/doctor.py

@@ -2,10 +2,7 @@
 import json
 import platform
 
-from slack_cli_hooks.protocol import (
-    Protocol,
-    build_protocol,
-)
+from slack_cli_hooks.protocol import Protocol, build_protocol
 
 PROTOCOL: Protocol
 

slack_cli_hooks/hooks/get_hooks.py

@@ -1,11 +1,8 @@
 #!/usr/bin/env python
 import json
 import sys
-from slack_cli_hooks.protocol import (
-    Protocol,
-    MessageBoundaryProtocol,
-    build_protocol,
-)
+
+from slack_cli_hooks.protocol import DefaultProtocol, MessageBoundaryProtocol, Protocol, build_protocol
 
 PROTOCOL: Protocol
 
@@ -22,7 +19,7 @@
     },
     "config": {
         "watch": {"filter-regex": "(^manifest\\.json$)", "paths": ["."]},
-        "protocol-version": [MessageBoundaryProtocol.name],
+        "protocol-version": [MessageBoundaryProtocol.name, DefaultProtocol.name],
         "sdk-managed-connection-enabled": True,
     },
     "runtime": "python",

slack_cli_hooks/protocol/__init__.py

@@ -1,13 +1,12 @@
 import argparse
 import sys
 from typing import List
+
+from .default_protocol import DefaultProtocol
 from .message_boundary_protocol import MessageBoundaryProtocol
 from .protocol import Protocol
 
-__all__ = [
-    "MessageBoundaryProtocol",
-    "Protocol",
-]
+__all__ = ["DefaultProtocol" "MessageBoundaryProtocol", "Protocol"]
 
 
 def build_protocol(argv: List[str] = sys.argv[1:]) -> Protocol:
@@ -19,4 +18,4 @@ def build_protocol(argv: List[str] = sys.argv[1:]) -> Protocol:
 
     if args.protocol == MessageBoundaryProtocol.name:
         return MessageBoundaryProtocol(boundary=args.boundary)
-    raise NotImplementedError
+    return DefaultProtocol()

slack_cli_hooks/protocol/default_protocol.py

@@ -0,0 +1,24 @@
+from .protocol import Protocol
+
+
+class DefaultProtocol(Protocol):
+    name: str = "default"
+
+    def debug(self, msg: str, *args, **kwargs):
+        """Nothing will be logged here"""
+        pass
+
+    def info(self, msg: str, *args, **kwargs):
+        """Nothing will be logged here"""
+        pass
+
+    def warning(self, msg: str, *args, **kwargs):
+        """Nothing will be logged here"""
+        pass
+
+    def error(self, msg: str, *args, **kwargs):
+        """Nothing will be logged here"""
+        pass
+
+    def respond(self, data: str):
+        print(data)

slack_cli_hooks/protocol/message_boundary_protocol.py

@@ -1,4 +1,5 @@
 import logging
+
 from .protocol import Protocol
 
 

tests/mock_protocol.py

@@ -1,4 +1,5 @@
 from unittest.mock import Mock
+
 from slack_cli_hooks.protocol.protocol import Protocol
 
 

tests/mock_socket_mode_server.py

@@ -1,9 +1,10 @@
 import json
 import threading
 import time
-from urllib.request import urlopen
-from urllib.error import URLError
 from unittest import TestCase
+from urllib.error import URLError
+from urllib.request import urlopen
+
 from flask import Flask
 from gevent import pywsgi
 from geventwebsocket.handler import WebSocketHandler

tests/mock_web_api_server.py

@@ -5,7 +5,7 @@
 from http.server import HTTPServer, SimpleHTTPRequestHandler
 from typing import Type
 from unittest import TestCase
-from urllib.parse import urlparse, ParseResult
+from urllib.parse import ParseResult, urlparse
 
 
 class MockHandler(SimpleHTTPRequestHandler):

tests/scenario_test/test_app/app.py

@@ -1,7 +1,7 @@
 import os
 
-from slack_sdk import WebClient
 from slack_bolt.app import App
+from slack_sdk import WebClient
 from utils import get_test_socket_mode_handler, wait_for_test_socket_connection
 
 web_client = WebClient(base_url="http://localhost:8888", token=os.environ.get("SLACK_BOT_TOKEN"))

tests/scenario_test/test_app/my_app.py

@@ -1,7 +1,7 @@
 import os
 
-from slack_sdk import WebClient
 from slack_bolt.app import App
+from slack_sdk import WebClient
 from utils import get_test_socket_mode_handler, wait_for_test_socket_connection
 
 web_client = WebClient(base_url="http://localhost:8888", token=os.environ.get("SLACK_BOT_TOKEN"))

tests/scenario_test/test_app/utils.py

@@ -1,6 +1,6 @@
 import time
-
 from typing import Optional
+
 from slack_bolt.adapter.socket_mode.builtin import SocketModeHandler
 from slack_bolt.app.app import App
 

tests/scenario_test/test_get_hooks.py

@@ -20,7 +20,6 @@ def test_get_manifest(self, capsys):
         runpy.run_module(get_hooks.__name__, run_name="__main__", alter_sys=False)
 
         out, err = capsys.readouterr()
-
         json_response = json.loads(out)
         assert err == ""
         assert "hooks" in json_response

tests/scenario_test/test_get_manifest.py

@@ -3,7 +3,9 @@
 import runpy
 import sys
 from unittest.mock import patch
+
 import pytest
+
 from slack_cli_hooks.error import CliError
 from slack_cli_hooks.hooks import get_manifest
 

tests/scenario_test/test_start.py

@@ -1,10 +1,11 @@
+import os
 import runpy
 import sys
 from unittest.mock import patch
+
 import pytest
-import os
-from slack_cli_hooks.error import CliError
 
+from slack_cli_hooks.error import CliError
 from slack_cli_hooks.hooks import start
 from tests.mock_socket_mode_server import start_socket_mode_server, stop_socket_mode_server
 from tests.mock_web_api_server import cleanup_mock_web_api_server, setup_mock_web_api_server

tests/slack_cli_hooks/hooks/test_check_update.py

@@ -2,8 +2,8 @@
 from urllib import request
 
 import pytest
-
 from packaging.version import Version
+
 from slack_cli_hooks.error import PypiError
 from slack_cli_hooks.hooks import check_update
 from slack_cli_hooks.hooks.check_update import (

tests/slack_cli_hooks/hooks/test_get_hooks.py

@@ -1,4 +1,5 @@
 import re
+
 from slack_cli_hooks.hooks.get_hooks import hooks_payload
 
 
@@ -15,7 +16,7 @@ def test_hooks_payload_config(self):
         config = hooks_payload["config"]
 
         assert config["sdk-managed-connection-enabled"] is True
-        assert config["protocol-version"] == ["message-boundaries"]
+        assert config["protocol-version"] == ["message-boundaries", "default"]
 
     def test_hooks_watch_regex(self):
         config = hooks_payload["config"]

tests/slack_cli_hooks/hooks/test_get_manifest.py

@@ -1,6 +1,7 @@
 from unittest import mock
 
 import pytest
+
 from slack_cli_hooks.error import CliError
 from slack_cli_hooks.hooks.get_manifest import filter_directories, find_file_path
 

tests/slack_cli_hooks/protocol/test_default_protocol.py

@@ -0,0 +1,41 @@
+from slack_cli_hooks.protocol import DefaultProtocol
+
+
+class TestDefaultProtocol:
+    def test_name(self):
+        assert DefaultProtocol.name == "default"
+
+    def test_debug(self, capsys):
+        DefaultProtocol().debug("test")
+
+        out, err = capsys.readouterr()
+        assert out == ""
+        assert err == ""
+
+    def test_info(self, capsys):
+        DefaultProtocol().info("test")
+
+        out, err = capsys.readouterr()
+        assert out == ""
+        assert err == ""
+
+    def test_warning(self, capsys):
+        DefaultProtocol().warning("test")
+
+        out, err = capsys.readouterr()
+        assert out == ""
+        assert err == ""
+
+    def test_error(self, capsys):
+        DefaultProtocol().error("test")
+
+        out, err = capsys.readouterr()
+        assert out == ""
+        assert err == ""
+
+    def test_respond(self, capsys):
+        DefaultProtocol().respond("test")
+
+        out, err = capsys.readouterr()
+        assert out == "test\n"
+        assert err == ""

tests/slack_cli_hooks/protocol/test_protocol_factory.py

@@ -1,14 +1,13 @@
-from slack_cli_hooks.protocol import build_protocol, MessageBoundaryProtocol, Protocol
+from slack_cli_hooks.protocol import MessageBoundaryProtocol, Protocol, build_protocol
+from slack_cli_hooks.protocol.default_protocol import DefaultProtocol
 
 
 class TestProtocolFactory:
     def test_default(self):
         args = []
-        try:
-            build_protocol(args)
-            assert False, "Expected an exception to be thrown"
-        except Exception as e:
-            assert isinstance(e, NotImplementedError)
+        protocol = build_protocol(args)
+        assert isinstance(protocol, Protocol)
+        assert isinstance(protocol, DefaultProtocol)
 
     def test_message_boundaries(self):
         args = [f"--protocol={MessageBoundaryProtocol.name}", "--bound=boundary"]