Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: @slack/[email protected], @slack/[email protected] #2118

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Release: @slack/[email protected], @slack/[email protected] #2118

merged 2 commits into from
Dec 6, 2024

Conversation

hello-ashleyintech
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech commented Dec 6, 2024 •
edited
Loading

Summary

This PR releases the following new versions:

Requirements (place an x in each [ ])

@hello-ashleyintech hello-ashleyintech added pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` release labels Dec 6, 2024
@hello-ashleyintech hello-ashleyintech requested a review from a team December 6, 2024 16:49
@hello-ashleyintech hello-ashleyintech self-assigned this Dec 6, 2024
@hello-ashleyintech hello-ashleyintech mentioned this pull request Dec 6, 2024
Closed
7 tasks
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (96d846a) to head (b4684c4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2118   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files          38       38           
  Lines       10317    10317           
  Branches      647      647           
=======================================
  Hits         9457     9457           
  Misses        848      848           
  Partials       12       12
Flag Coverage Δ
cli-hooks 95.24% <ø> (ø)
cli-test 94.48% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 58.22% <ø> (ø)
web-api 96.88% <ø> (ø)
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

zimeg
zimeg reviewed Dec 6, 2024
View reviewed changes
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question before merging!

packages/webhook/package.json Outdated Show resolved Hide resolved
@hello-ashleyintech hello-ashleyintech changed the title Release: @slack/[email protected], @slack/[email protected] Release: @slack/[email protected], @slack/[email protected] Dec 6, 2024
zimeg
zimeg approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast follows and seeing these updates through! 🙏

@zimeg
Copy link
Member

zimeg commented Dec 6, 2024

The @slack/oauth package just popped into mind which uses @slack/web-api - bumping @slack/web-api might be needed too? 😓

Not sure if this was planned for a separate PR, but I think it could be changed here too. Though separate PRs feels a bit more stable? Your call!

@hello-ashleyintech
Copy link
Contributor Author

@zimeg for public transparency will also leave this comment here- I will merge this PR, release web-api and webhooks, and then on Monday I'm going to dig into updating those dependencies and releasing - so for Bolt, socket-mode, and oauth (thus far)! I'll look into other places as well where we may need to update 🙌

@hello-ashleyintech hello-ashleyintech merged commit 1f8e880 into main Dec 6, 2024
57 checks passed
@hello-ashleyintech hello-ashleyintech deleted the ah-webhook-7.1.0-release branch December 6, 2024 19:21
@hello-ashleyintech hello-ashleyintech mentioned this pull request Dec 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimeg zimeg zimeg approved these changes

Assignees

@hello-ashleyintech hello-ashleyintech

Labels
pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hello-ashleyintech @zimeg