-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): declare express types in peer dependencies #2410
base: main
Are you sure you want to change the base?
Conversation
Thanks for the contribution! Before we can merge this, we need @Grmiade to sign the Salesforce Inc. Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me thanks for working on this 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to update npm install
-> npm install --include=optional
in the following files to make the tests pass and update the maintainer experience
Let me know if you would like me to make these changes instead
Summary
Fix #2409
I took the opportunity to also move
express
in peer dependencies since the project is not always used on top of express.Requirements (place an
x
in each[ ]
)