Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): declare express types in peer dependencies #2410

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Grmiade
Copy link

@Grmiade Grmiade commented Jan 28, 2025

Summary

Fix #2409

I took the opportunity to also move express in peer dependencies since the project is not always used on top of express.

Requirements (place an x in each [ ])

Copy link

Thanks for the contribution! Before we can merge this, we need @Grmiade to sign the Salesforce Inc. Contributor License Agreement.

@Grmiade Grmiade changed the title fix(deps): declare express types in dependencies fix(deps): declare express types in peer dependencies Jan 28, 2025
@Grmiade Grmiade changed the title fix(deps): declare express types in peer dependencies feat(deps): declare express types in peer dependencies Jan 28, 2025
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me thanks for working on this 💯

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to update npm install -> npm install --include=optional in the following files to make the tests pass and update the maintainer experience

Let me know if you would like me to make these changes instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express types should be included in dependencies
2 participants