Use global executionContext #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcarter97
force-pushed
the
global-execution-context
branch
from
1cfd462 to
07e7271
Compare
bcarter97
force-pushed
the
global-execution-context
branch
from
07e7271 to
cbe8d05
Compare
| import scala.concurrent.duration.* | ||
|
|
||
| trait AsyncIntSpec[F[_]] extends AsyncWordSpec with AsyncIOSpec with Matchers with OptionValues with Eventually { | ||
| override given patienceConfig: PatienceConfig = PatienceConfig(30.seconds, 500.millis) | ||
|
|
||
| override given executionContext: ExecutionContext = ExecutionContext.global |
There was a problem hiding this comment.
this is only needed when using the CatsResource trait i thought?
There was a problem hiding this comment.
The last test in TopicLoaderIntSpec, loadAndRun sometimes fails and I'm trying to rule out it's to do with the resource being terminated before it can finish... but you're right, the global EC is only needed with the CatsResource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Definition of Done:
The Below tasks should be completed before marking a PR as ready for review.