Add Contributing Guidelines For Skorch #1087
Open
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParagEkbote
commented
Jan 8, 2025
ParagEkbote
commented
Jan 8, 2025
|
Could you please review the changes? cc: @BenjaminBossan |
BenjaminBossan
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Thanks for creating this PR to add contribution guidelines.
What is or is not needed can be highly subjective, my comments are just my personal opinions. Maybe @githubnemo and @thomasjpfan have different opinions.
ParagEkbote
commented
Jan 14, 2025
|
I'd also really appreciate @githubnemo and @thomasjpfan's review as well before moving forward. Could you please review the changes? |
|
Could you please review the changes? cc: @githubnemo, @thomasjpfan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229
I have created an initial draft of the contributing guidelines.
Please let me know if the required improvements are needed and I will make the necessary changes.
cc: @BenjaminBossan